fixed input text code section #6625
Conversation
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit 65cec2d at: https://687130b9d1c0f917a74ae999--layer5.netlify.app |
|
I guess there are 2 part of issue and i don't know which one u have resolved. @ARYANSHAH1567 |
My bad, i didnt intercept the issue correctly, will fix one of the two issues and update the pr, Can u please tell me what text has to be added in the Code section of text-input because its currently showing "Sorry this page is still under work" |
|
U have answered ur own question. @ARYANSHAH1567 |
There was a problem hiding this comment.
For the code block you can refer this : #6541 @ARYANSHAH1567
|
@ARYANSHAH1567 Add it as an agenda item to the meeting minutes, if you would :) |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit f1a001b at: https://6874baf313bcbdd9d6eba3a1--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit b35acbe at: https://6874df2a0f821a9ba62aff3a--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit 43991dd at: https://68754d5d51c69f8cf1d1b599--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit c4cd765 at: https://6875530b51c69fa143d1b27e--layer5.netlify.app |
|
@vr-varad @leecalcote Can u review the PR? i have completed the code section for text input, u can see it at |
|
@ARYANSHAH1567 follow this pr #6605 |
Hey @vr-varad, |
|
LGTM |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit c8f9197 at: https://6883c133f7d4b69697968ced--layer5.netlify.app |
There was a problem hiding this comment.
- There is still repetitive text in both overview and code.
- There is no parameter as size in
Input. ref1 ref2 that is why there is no difference in all 3 input boxes.
@ARYANSHAH1567 mind changing it in all 3 sections and adding appropriate use case and code?
Yeah okay, i will look to complete it and fix it in all three sections |
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
|
🚀 Preview for commit 12b54e9 at: https://68870cb7381546d1b73e38c0--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
…/ARYANSHAH1567/layer5 into aryanshah/fix_input_text_section
|
🚀 Preview for commit e2acba5 at: https://688ef241a869ce561223c5a7--layer5.netlify.app |
|
🚀 Preview for commit 7cf8588 at: https://688f04209921b284b79fb5f4--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
…/ARYANSHAH1567/layer5 into aryanshah/fix_input_text_section
|
🚀 Preview for commit 7c74207 at: https://6896f6d8245eab21f86476b9--layer5.netlify.app |
|
🚀 Preview for commit e6b8041 at: https://6899192c3f756d24ae714025--layer5.netlify.app |
|
@vr-varad |
|
yes @ARYANSHAH1567 |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit 3b3fc8b at: https://6899b044613dbf09d61defea--layer5.netlify.app |
Signed-off-by: Aryan Shah <[email protected]>
|
🚀 Preview for commit 7e1b146 at: https://6899e98d50d587d4d2e14780--layer5.netlify.app |
|
@FaheemOnHub @vr-varad I have incorporated the changes suggested in meeting, changed it to "Component Props" |
|
🚀 Preview for commit 8a0d698 at: https://689b6498721ab745ea48ba95--layer5.netlify.app |
Description
This PR fixes #6331
Notes for Reviewers
I have Added a max-width for the sidebar and allowng a vertical scrolling feature, Also the text-input's code section which earlier showed "Sorry this page is still under work" has been replaced with the neccessary code
Signed commits